Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 814723002: Revert of Allow build under GTK+ 2.24. (Closed)

Created:
6 years ago by Kunihiko Sakamoto
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow build under GTK+ 2.24. (patchset #1 id:1 of https://codereview.chromium.org/813823003/) Reason for revert: broke GoogleChrome Linux Build http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/38993 FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a ia32 -c stable dpkg-shlibdeps: warning: binaries to analyze should already be installed in their package's directory. 13c13 < libglib2.0-0 (>= 2.28.0) --- > libglib2.0-0 (>= 2.26.0) ERROR: Shared library dependencies changed! If this is intentional, please update: chrome/installer/linux/debian/expected_deps_ia32 chrome/installer/linux/debian/expected_deps_x64 Probably you need to change those expected_deps files too. Original issue's description: > Allow build under GTK+ 2.24. > > Some parts of libgtk2ui use newer function and #define names than what's in > GTK+ 2.24, which is what ships with RHEL/CentOS 6.6. This commit allows > Chromium to work on RHEL/CentOS 6.6 by checking for the appropriate GTK version > and using the appropriate API. > > This is the same as the already reviewed issue 806843004, just submitted from > the correct email address. > https://codereview.chromium.org/806843004/ > > BUG=443005 > R=erg@chromium.org > > Committed: https://crrev.com/5cd198a55b73f7f32e5e8225aa6d8ac0bc39a2fb > Cr-Commit-Position: refs/heads/master@{#308883} TBR=erg@chromium.org,ian.scott@arteris.com NOTREECHECKS=true NOTRY=true BUG=443005 Committed: https://crrev.com/81cb11d8b928ad9ce62b1e1e64cc33fdd51cf24a Cr-Commit-Position: refs/heads/master@{#308929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kunihiko Sakamoto
Created Revert of Allow build under GTK+ 2.24.
6 years ago (2014-12-18 03:01:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814723002/1
6 years ago (2014-12-18 03:02:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 03:03:55 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-18 03:04:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81cb11d8b928ad9ce62b1e1e64cc33fdd51cf24a
Cr-Commit-Position: refs/heads/master@{#308929}

Powered by Google App Engine
This is Rietveld 408576698