Issue 814683003: win: FILE_PATH_LITERALs in http_multipart_builder_test.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 814683003: win: FILE_PATH_LITERALs in http_multipart_builder_test.cc (Closed)

Created:
5 years, 11 months ago by scottmg

Modified:
5 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@http-body-test

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: FILE_PATH_LITERALs in http_multipart_builder_test.cc clang-format wanted to rewrap this way. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9b05b910d4e31d9a792481c2bdd37cde5d8a340d

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -14 lines)			Patch
	M	util/net/http_multipart_builder_test.cc	View		3 chunks	+35 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

LGTM. These wrapping changes are OK. I actually like them better than what was there ...

5 years, 11 months ago (2015-01-07 23:05:49 UTC) #2

scottmg

Committed patchset #1 (id:1) manually as 9b05b910d4e31d9a792481c2bdd37cde5d8a340d (presubmit successful).

5 years, 11 months ago (2015-01-07 23:07:47 UTC) #4

Robert Sesek

5 years, 11 months ago (2015-01-07 23:08:34 UTC) #5

Message was sent while issue was closed.

On 2015/01/07 23:05:49, Mark Mentovai wrote:
> LGTM. These wrapping changes are OK. I actually like them better than what was
> there previously.

Me too. I can't be bothered to set up clang-format.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages