Issue 814673002: replace COMPILE_ASSERT with static_assert in web/

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+549 lines, -549 lines)			Patch
M	Source/web/AssertMatchingEnums.cpp	View	1 2	1 chunk	+523 lines, -523 lines	0 comments	Download
M	Source/web/AssociatedURLLoader.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	Source/web/WebInputEvent.cpp	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2	1 chunk	+10 lines, -10 lines	0 comments	Download
M	Source/web/mac/WebScrollbarTheme.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814673002/20001

6 years ago (2014-12-19 12:21:27 UTC) #5

commit-bot: I haz the power

Failed to apply patch for Source/web/AssertMatchingEnums.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

6 years ago (2014-12-19 12:21:37 UTC) #7

Failed to apply patch for Source/web/AssertMatchingEnums.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/AssertMatchingEnums.cpp
  Hunk #1 FAILED at 137.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/AssertMatchingEnums.cpp.rej

Patch:       Source/web/AssertMatchingEnums.cpp
Index: Source/web/AssertMatchingEnums.cpp
diff --git a/Source/web/AssertMatchingEnums.cpp
b/Source/web/AssertMatchingEnums.cpp
index
5aa92d90344cfc5ff348800d4825c4e6176dc99b..d898fee2bac97621efb234eaaaf098d5f53a02d4
100644
--- a/Source/web/AssertMatchingEnums.cpp
+++ b/Source/web/AssertMatchingEnums.cpp
@@ -137,524 +137,524 @@
 
 namespace blink {
 
-#define COMPILE_ASSERT_MATCHING_ENUM(public_name, core_name) \
-    COMPILE_ASSERT(int(public_name) == int(core_name), mismatching_enums)
-
-#define COMPILE_ASSERT_MATCHING_UINT64(public_name, core_name) \
-    COMPILE_ASSERT(public_name == core_name, mismatching_enums)
-
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventActiveDescendantChanged,
AXObjectCache::AXActiveDescendantChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventAlert, AXObjectCache::AXAlert);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventAriaAttributeChanged,
AXObjectCache::AXAriaAttributeChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventAutocorrectionOccured,
AXObjectCache::AXAutocorrectionOccured);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventBlur, AXObjectCache::AXBlur);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventCheckedStateChanged,
AXObjectCache::AXCheckedStateChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventChildrenChanged,
AXObjectCache::AXChildrenChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventFocus,
AXObjectCache::AXFocusedUIElementChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventHide, AXObjectCache::AXHide);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventInvalidStatusChanged,
AXObjectCache::AXInvalidStatusChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventLayoutComplete,
AXObjectCache::AXLayoutComplete);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventLiveRegionChanged,
AXObjectCache::AXLiveRegionChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventLoadComplete,
AXObjectCache::AXLoadComplete);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventLocationChanged,
AXObjectCache::AXLocationChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventMenuListItemSelected,
AXObjectCache::AXMenuListItemSelected);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventMenuListValueChanged,
AXObjectCache::AXMenuListValueChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventRowCollapsed,
AXObjectCache::AXRowCollapsed);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventRowCountChanged,
AXObjectCache::AXRowCountChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventRowExpanded,
AXObjectCache::AXRowExpanded);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventScrollPositionChanged,
AXObjectCache::AXScrollPositionChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventScrolledToAnchor,
AXObjectCache::AXScrolledToAnchor);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventSelectedChildrenChanged,
AXObjectCache::AXSelectedChildrenChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventSelectedTextChanged,
AXObjectCache::AXSelectedTextChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventShow, AXObjectCache::AXShow);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventTextChanged,
AXObjectCache::AXTextChanged);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventTextInserted,
AXObjectCache::AXTextInserted);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventTextRemoved,
AXObjectCache::AXTextRemoved);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXEventValueChanged,
AXObjectCache::AXValueChanged);
-
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleAlertDialog, AlertDialogRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleAlert, AlertRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleAnnotation, AnnotationRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleApplication, ApplicationRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleArticle, ArticleRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleBanner, BannerRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleBlockquote, BlockquoteRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleBusyIndicator, BusyIndicatorRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleButton, ButtonRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCanvas, CanvasRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCell, CellRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCheckBox, CheckBoxRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColorWell, ColorWellRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColumnHeader, ColumnHeaderRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColumn, ColumnRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleComboBox, ComboBoxRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleComplementary, ComplementaryRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleContentInfo, ContentInfoRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDate, DateRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDateTime, DateTimeRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDefinition, DefinitionRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDescriptionListDetail,
DescriptionListDetailRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDescriptionList, DescriptionListRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDescriptionListTerm,
DescriptionListTermRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDetails, DetailsRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDialog, DialogRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDirectory, DirectoryRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDisclosureTriangle,
DisclosureTriangleRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDiv, DivRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleDocument, DocumentRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleEmbeddedObject, EmbeddedObjectRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleFigcaption, FigcaptionRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleFigure, FigureRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleFooter, FooterRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleForm, FormRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleGrid, GridRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleGroup, GroupRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleHeading, HeadingRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleIframe, IframeRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleIframePresentational,
IframePresentationalRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleIgnored, IgnoredRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleImageMapLink, ImageMapLinkRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleImageMap, ImageMapRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleImage, ImageRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleInlineTextBox, InlineTextBoxRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleLabel, LabelRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleLegend, LegendRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleLink, LinkRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleListBoxOption, ListBoxOptionRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleListBox, ListBoxRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleListItem, ListItemRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleListMarker, ListMarkerRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleList, ListRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleLog, LogRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMain, MainRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMarquee, MarqueeRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMath, MathRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuBar, MenuBarRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuButton, MenuButtonRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuItem, MenuItemRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuItemCheckBox, MenuItemCheckBoxRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuItemRadio, MenuItemRadioRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuListOption, MenuListOptionRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenuListPopup, MenuListPopupRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMenu, MenuRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleMeter, MeterRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleNavigation, NavigationRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleNone, NoneRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleNote, NoteRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleOutline, OutlineRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleParagraph, ParagraphRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRolePopUpButton, PopUpButtonRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRolePre, PreRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRolePresentational, PresentationalRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleProgressIndicator,
ProgressIndicatorRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRadioButton, RadioButtonRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRadioGroup, RadioGroupRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRegion, RegionRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRootWebArea, RootWebAreaRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRowHeader, RowHeaderRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRow, RowRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRuby, RubyRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleRuler, RulerRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSVGRoot, SVGRootRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleScrollArea, ScrollAreaRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleScrollBar, ScrollBarRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSeamlessWebArea, SeamlessWebAreaRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSearch, SearchRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSlider, SliderRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSliderThumb, SliderThumbRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSpinButtonPart, SpinButtonPartRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSpinButton, SpinButtonRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleSplitter, SplitterRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleStaticText, StaticTextRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleStatus, StatusRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTabGroup, TabGroupRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTabList, TabListRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTabPanel, TabPanelRole);
-COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleTab, Tab…
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814673002/40001

6 years ago (2014-12-19 12:35:08 UTC) #9

commit-bot: I haz the power

6 years ago (2014-12-19 14:36:04 UTC) #10

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187534

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages