Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2104)

Unified Diff: build/android/pylib/remote/device/remote_device_helper.py

Issue 814653003: Clean up logging and add device randomization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/remote/device/remote_device_helper.py
diff --git a/build/android/pylib/remote/device/remote_device_helper.py b/build/android/pylib/remote/device/remote_device_helper.py
index a4cd4887c56a997470b0a9b4026ceac2b1cc1961..abd09471ad9cbf5e4b3671be101470bd7063fdfc 100644
--- a/build/android/pylib/remote/device/remote_device_helper.py
+++ b/build/android/pylib/remote/device/remote_device_helper.py
@@ -4,6 +4,7 @@
"""Common functions and Exceptions for remote_device_*"""
+import logging
class RemoteDeviceError(Exception):
"""Exception to throw when problems occur with remote device service."""
@@ -19,3 +20,8 @@ def TestHttpResponse(response, error_msg):
"""
if response.status_code != 200:
raise RemoteDeviceError(error_msg)
+
+
+def SetLogging(verbose_count, level):
+ if verbose_count < 2:
+ logging.disable(level)
jbudorick 2015/01/05 16:52:29 I'm concerned with how this interacts with threadi
rnephew (Wrong account) 2015/01/05 19:31:54 Added warning comment for now. A better solution w

Powered by Google App Engine
This is Rietveld 408576698