build/android/pylib/remote/device/remote_device_helper.py - Issue 814653003: Clean up logging and add device randomization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/remote/device/remote_device_helper.py

Issue 814653003: Clean up logging and add device randomization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/android/pylib/remote/device/remote_device_environment.py ('k') | build/android/pylib/remote/device/remote_device_test_run.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Common functions and Exceptions for remote_device_*"""	5 """Common functions and Exceptions for remote_device_*"""

6	6

	7 import logging
	jbudorick 2015/01/07 18:15:30 nit: remove this, it's no longer necessary nit: remove this, it's no longer necessary rnephew (Wrong account) 2015/01/07 18:18:42 Done. Show quoted text On 2015/01/07 18:15:30, jbudorick wrote: > nit: remove this, it's no longer necessary Done.
7	8

8 class RemoteDeviceError(Exception):	9 class RemoteDeviceError(Exception):

9 """Exception to throw when problems occur with remote device service."""	10 """Exception to throw when problems occur with remote device service."""

10 pass	11 pass

11	12

12	13

13 def TestHttpResponse(response, error_msg):	14 def TestHttpResponse(response, error_msg):

14 """Checks the Http response from remote device service.	15 """Checks the Http response from remote device service.

15	16

16 Args:	17 Args:

17 response: response dict from the remote device service.	18 response: response dict from the remote device service.

18 error_msg: Error message to display if bad response is seen.	19 error_msg: Error message to display if bad response is seen.

19 """	20 """

20 if response.status_code != 200:	21 if response.status_code != 200:

21 raise RemoteDeviceError(error_msg)	22 raise RemoteDeviceError(error_msg)

OLD	NEW