Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 814573003: Make ImageFrame be transparent by default (Closed)

Created:
6 years ago by enne (OOO)
Modified:
6 years ago
Reviewers:
pdr.
CC:
blink-reviews, chrishtr
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ImageFrame be transparent by default Previously, ImageFrame was initialized to not have alpha, which means that it would be considered to be opaque by other parts of the system. Instead, initialize it to think it has alpha when it isn't known (which the rest of the class also does). This fix prevents flakiness in painting where loading caused raciness with whether or not a transparent background image would cause a background color to not get painted because of different values being returned from backgroundHasOpaqueTopLayer. BUG=442991 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
enne (OOO)
6 years ago (2014-12-17 19:55:05 UTC) #2
pdr.
lgtm
6 years ago (2014-12-17 20:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814573003/1
6 years ago (2014-12-17 20:07:57 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 21:27:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187404

Powered by Google App Engine
This is Rietveld 408576698