Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 814563004: Update a comment with a link to a historic source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: except Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 0dc1a940c9ba6f7f0699471fc993cb064b4e5fe7..f2b03f28867707b664499c2327b9aa4d5d4ac485 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3811,11 +3811,10 @@ void RenderFrameImpl::SendDidCommitProvisionalLoad(
// generated a new session history entry. When they do generate a session
// history entry, it means the user initiated the navigation and we should
// mark it as such.
- bool is_history_navigation = commit_type == blink::WebBackForwardCommit;
- if (is_history_navigation || ds->replacesCurrentHistoryItem())
- params.transition = ui::PAGE_TRANSITION_AUTO_SUBFRAME;
- else
+ if (commit_type == blink::WebStandardCommit)
Avi (use Gerrit) 2015/02/17 15:51:28 It turns out that I should have been looking at th
Charlie Reis 2015/02/18 17:57:37 Ok. What's an example that shows the difference?
Avi (use Gerrit) 2015/02/18 18:33:12 The reload. That's a blink::WebHistoryInertCommit
Charlie Reis 2015/02/18 18:45:04 Acknowledged.
params.transition = ui::PAGE_TRANSITION_MANUAL_SUBFRAME;
+ else
+ params.transition = ui::PAGE_TRANSITION_AUTO_SUBFRAME;
DCHECK(!navigation_state->history_list_was_cleared());
params.history_list_was_cleared = false;

Powered by Google App Engine
This is Rietveld 408576698