chrome/browser/translate/translate_manager_render_view_host_unittest.cc - Issue 814563004: Update a comment with a link to a historic source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 814563004: Update a comment with a link to a historic source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: except Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

index a9d805b56f74dba8504cf634506a5390f5e88a7c..7772956bdc8f189c49db51028476afc0b87088ec 100644

--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

@@ -894,12 +894,12 @@ TEST_F(TranslateManagerRenderViewHostTest, CloseInfoBarInSubframeNavigation) {

// Simulate a sub-frame auto-navigating.

subframe_tester->SendNavigateWithTransition(

- 1, GURL("http://pub.com"), ui::PAGE_TRANSITION_AUTO_SUBFRAME);

+ 0, GURL("http://pub.com"), ui::PAGE_TRANSITION_AUTO_SUBFRAME);

EXPECT_TRUE(GetTranslateInfoBar() == NULL);

// Simulate the user navigating in a sub-frame.

subframe_tester->SendNavigateWithTransition(

- 2, GURL("http://pub.com"), ui::PAGE_TRANSITION_MANUAL_SUBFRAME);

+ 1, GURL("http://pub.com"), ui::PAGE_TRANSITION_MANUAL_SUBFRAME);

EXPECT_TRUE(GetTranslateInfoBar() == NULL);

// Navigate out of page, a new infobar should show.