content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 814563004: Update a comment with a link to a historic source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 814563004: Update a comment with a link to a historic source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index aa16932bab178ec822425b8e2f2a3f3cd1fb7c1e..a27cffe9cc0ead63d99f578410db5e5ce8321a81 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -2050,6 +2050,7 @@ TEST_F(NavigationControllerTest, BackSubframe) {

const GURL url3("http://foo3");

params.page_id = 2;

params.url = url3;

+ params.transition = ui::PAGE_TRANSITION_MANUAL_SUBFRAME;

EXPECT_TRUE(controller.RendererDidNavigate(main_test_rfh(), params,

&details));

EXPECT_EQ(1U, navigation_entry_committed_counter_);

@@ -2059,8 +2060,9 @@ TEST_F(NavigationControllerTest, BackSubframe) {

// Go back one.

controller.GoBack();

- params.url = url2;

params.page_id = 1;

+ params.url = url2;

+ params.transition = ui::PAGE_TRANSITION_AUTO_SUBFRAME;

EXPECT_TRUE(controller.RendererDidNavigate(main_test_rfh(), params,

&details));

EXPECT_EQ(1U, navigation_entry_committed_counter_);

@@ -2072,8 +2074,9 @@ TEST_F(NavigationControllerTest, BackSubframe) {

// Go back one more.

controller.GoBack();

- params.url = url1;

params.page_id = 0;

+ params.url = url1;

+ params.transition = ui::PAGE_TRANSITION_AUTO_SUBFRAME;

EXPECT_TRUE(controller.RendererDidNavigate(main_test_rfh(), params,

&details));

EXPECT_EQ(1U, navigation_entry_committed_counter_);