Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 814563004: Update a comment with a link to a historic source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index f4f184ba42b9889896b76abd0b6682735ed53464..a436d79ff419d7526bafd98fa34b86697468ad03 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1215,7 +1215,12 @@ void NavigationControllerImpl::RendererDidNavigateNewSubframe(
const FrameHostMsg_DidCommitProvisionalLoad_Params& params) {
if (ui::PageTransitionCoreTypeIs(params.transition,
ui::PAGE_TRANSITION_AUTO_SUBFRAME)) {
- // This is not user-initiated. Ignore.
+ // The old comment here was "This is not user-initiated. Ignore." This is a
+ // weird scenario, where we've determined that this was a new subframe
+ // navigation but say "never mind" based on a flag from the renderer.
Charlie Reis 2015/01/15 22:12:09 Maybe I misunderstood this case before, but I thou
Avi (use Gerrit) 2015/01/15 22:16:52 Will investigate.
Avi (use Gerrit) 2015/01/16 21:06:26 Isn't that what RendererDidNavigateAutoSubframe is
+ //
+ // This dates back to http://crrev.com/115919 and the handling of immediate
Charlie Reis 2015/01/15 22:12:09 This revision is a DEPS roll. Did you mean http:/
Avi (use Gerrit) 2015/01/15 22:16:52 Yes. I used the auto-shortener and am bummed that
+ // redirects. TODO(avi): Is this still valid?
DiscardNonCommittedEntriesInternal();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698