Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 814533002: Introduce web::TestWebThreadBundle (Closed)

Created:
6 years ago by sdefresne
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@includes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce web::TestWebThreadBundle Introduce web::TestWebThreadBundle that delegates to content::TestBrowserThreadBundle until web::WebThread has a proper implementation on iOS. Build public/test/test_browser_thread_bundle.cc on iOS. BUG=442292 Committed: https://crrev.com/48616f15d4a9a23127248e3ce3aa60176ae738ec Cr-Commit-Position: refs/heads/master@{#309429}

Patch Set 1 #

Patch Set 2 : Fix DEPS #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/DEPS View 1 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/public/test/test_web_thread_bundle.h View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
A ios/web/test/test_web_thread_bundle.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sdefresne
stuartmorgan: could you review? If you think this is clean enough, I'll send it to ...
6 years ago (2014-12-17 14:25:06 UTC) #2
stuartmorgan
lgtm
6 years ago (2014-12-17 21:10:54 UTC) #3
sdefresne
jochen: please review the new DEPS on //content/public/test/test_browser_thread_bundle.cc Note that I also enable the compilation ...
6 years ago (2014-12-18 14:47:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/814533002/diff/20001/ios/web/test/test_web_thread_bundle.cc File ios/web/test/test_web_thread_bundle.cc (right): https://codereview.chromium.org/814533002/diff/20001/ios/web/test/test_web_thread_bundle.cc#newcode41 ios/web/test/test_web_thread_bundle.cc:41: }; nit. DISALLOW_COPY_AND_ASSIGN()
6 years ago (2014-12-22 14:34:05 UTC) #6
sdefresne
Thank you for the review. https://codereview.chromium.org/814533002/diff/20001/ios/web/test/test_web_thread_bundle.cc File ios/web/test/test_web_thread_bundle.cc (right): https://codereview.chromium.org/814533002/diff/20001/ios/web/test/test_web_thread_bundle.cc#newcode41 ios/web/test/test_web_thread_bundle.cc:41: }; On 2014/12/22 at ...
6 years ago (2014-12-22 14:50:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814533002/40001
6 years ago (2014-12-22 14:51:07 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 15:45:29 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-22 15:46:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/48616f15d4a9a23127248e3ce3aa60176ae738ec
Cr-Commit-Position: refs/heads/master@{#309429}

Powered by Google App Engine
This is Rietveld 408576698