Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 814403003: Update legacy Tuple-using code. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
Reviewers:
nasko, mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1580 lines, -1590 lines) Patch
M chrome/common/chrome_utility_messages.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_macros.h View 6 chunks +18 lines, -17 lines 0 comments Download
M ipc/ipc_message_utils.h View 3 chunks +58 lines, -58 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M testing/generate_gmock_mutant.py View 10 chunks +23 lines, -34 lines 0 comments Download
M testing/gmock_mutant.h View 106 chunks +1469 lines, -1469 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Avi (use Gerrit)
Ken, Nasko— It's Christmas refactoring time again. And while cleaning up Tuple is 95% mechanical, ...
6 years ago (2014-12-20 21:03:15 UTC) #2
Avi (use Gerrit)
On 2014/12/20 21:03:15, Avi wrote: > Ken, Nasko— > > It's Christmas refactoring time again. ...
6 years ago (2014-12-20 21:09:48 UTC) #3
Avi (use Gerrit)
mdempsky, here you go
6 years ago (2014-12-22 16:35:47 UTC) #5
mdempsky
lgtm
6 years ago (2014-12-22 16:40:45 UTC) #6
nasko
LGTM
6 years ago (2014-12-22 16:45:53 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/12f4b98357b9dedc93cb546aac0aece2c8d9e850 Cr-Commit-Position: refs/heads/master@{#309432}
6 years ago (2014-12-22 17:02:08 UTC) #8
Avi (use Gerrit)
6 years ago (2014-12-22 17:02:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
12f4b98357b9dedc93cb546aac0aece2c8d9e850.

Powered by Google App Engine
This is Rietveld 408576698