Chromium Code Reviews
Help | Chromium Project | Sign in
(178)

Issue 8143012: Fix library paths for preloading NSS on Ubuntu 11.10. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Lambros
Modified:
2 years, 6 months ago
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix library paths for preloading NSS on Ubuntu 11.10.


BUG=99053, 91962
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104421

Patch Set 1 #

Total comments: 7

Patch Set 2 : Add ARM support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Lint Patch
M crypto/nss_util.cc View 1 3 chunks +12 lines, -2 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 16
Lambros
2 years, 6 months ago #1
awong
http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc File crypto/nss_util.cc (right): http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc#newcode659 crypto/nss_util.cc:659: paths.push_back(FilePath("/usr/lib/x86_64-linux-gnu/nss")); Can we confirm with the ubuntu folks that ...
2 years, 6 months ago #2
Lambros
On 2011/10/05 18:07:42, awong wrote: > http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc > File crypto/nss_util.cc (right): > > http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc#newcode659 > ...
2 years, 6 months ago #3
awong
LGTM
2 years, 6 months ago #4
I haz the power (commit-bot)
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/8143012/1
2 years, 6 months ago #5
I haz the power (commit-bot)
Presubmit check for 8143012-1 failed and returned exit status 1. Running presubmit commit checks ...
2 years, 6 months ago #6
Lambros
agl: Please could I have OWNERS approval?
2 years, 6 months ago #7
agl
This is something for wtc to approve. Adding paths should be safe, at least, but ...
2 years, 6 months ago #8
wtc
Lambros: thanks for the patch. I really hope this is a duplicate of bug 91962 ...
2 years, 6 months ago #9
wtc
http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc File crypto/nss_util.cc (right): http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc#newcode659 crypto/nss_util.cc:659: paths.push_back(FilePath("/usr/lib/x86_64-linux-gnu/nss")); On 2011/10/05 18:07:42, awong wrote: > Can we ...
2 years, 6 months ago #10
Lambros
On 2011/10/06 01:06:44, wtc wrote: > Lambros: thanks for the patch. I really hope this ...
2 years, 6 months ago #11
wtc
Lambros: could you add 91962 to the BUG= field in the CL's commit message? Thanks. ...
2 years, 6 months ago #12
Lambros
http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc File crypto/nss_util.cc (right): http://codereview.chromium.org/8143012/diff/1/crypto/nss_util.cc#newcode662 crypto/nss_util.cc:662: #endif On 2011/10/06 01:06:44, wtc wrote: > Please test ...
2 years, 6 months ago #13
wtc
Patch Set 2 LGTM. Thanks!
2 years, 6 months ago #14
I haz the power (commit-bot)
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/8143012/12001
2 years, 6 months ago #15
I haz the power (commit-bot)
2 years, 6 months ago #16
Change committed as 104421
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6