Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 814273006: Don't DCHECK in AttachmentServiceProxyForTest when MessageLoop is absent (Closed)

Created:
5 years, 11 months ago by pavely
Modified:
5 years, 11 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't DCHECK in AttachmentServiceProxyForTest when MessageLoop is absent The code in AttachmentServiceProxyForTest::Create checks that base::ThreadTaskRunnerHandle::Get() returns valid runner in the incorrect way. Get() DCHECKs that there is valid MessageLoop. Instead it should check ThreadTaskRunnerHandle::IsSet(). BUG=449327 R=maniscalco@chromium.org Committed: https://crrev.com/a8e369960cfab093ffffc9dc9f0066cca2b56812 Cr-Commit-Position: refs/heads/master@{#311917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M sync/api/attachments/attachment_store.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_for_test.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pavely
PTAL.
5 years, 11 months ago (2015-01-16 01:08:30 UTC) #1
maniscalco
On 2015/01/16 01:08:30, pavely wrote: > PTAL. LGTM
5 years, 11 months ago (2015-01-16 01:27:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814273006/1
5 years, 11 months ago (2015-01-16 17:17:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 17:21:13 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 17:22:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e369960cfab093ffffc9dc9f0066cca2b56812
Cr-Commit-Position: refs/heads/master@{#311917}

Powered by Google App Engine
This is Rietveld 408576698