Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 814273005: Move application_manager from /mojo to /shell. (Closed)

Created:
5 years, 11 months ago by ppi
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move application_manager from /mojo to /shell. application_manager is an implementation detail of the shell. BUG=430984 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6384d09bde312ac7915a403f15003137b5268149

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Update include guards. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1491 lines) Patch
M mojo/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D mojo/application_manager/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/application_manager/application_loader.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/application_manager/application_loader.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/application_manager/application_manager.h View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/application_manager/application_manager.cc View 1 chunk +0 lines, -276 lines 0 comments Download
D mojo/application_manager/application_manager_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/application_manager/application_manager_unittest.cc View 1 chunk +0 lines, -673 lines 0 comments Download
D mojo/application_manager/shell_impl.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/application_manager/shell_impl.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/application_manager/test.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
M mojo/services/view_manager/public/cpp/tests/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M services/window_manager/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 6 chunks +6 lines, -5 lines 0 comments Download
M shell/android/android_handler_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/background_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/background_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/mojo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/native_viewport_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/ui_application_loader_android.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/ui_application_loader_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/application_manager/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
A + shell/application_manager/application_loader.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/application_manager/application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/application_manager/application_manager.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/application_manager/application_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + shell/application_manager/application_manager_export.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/application_manager/application_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + shell/application_manager/shell_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/application_manager/shell_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + shell/application_manager/test.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M shell/context.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/dynamic_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/external_application_listener_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/shell_test_helper.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi James, ptal.
5 years, 11 months ago (2015-01-15 23:44:35 UTC) #2
jamesr
https://codereview.chromium.org/814273005/diff/20001/shell/application_manager/shell_impl.h File shell/application_manager/shell_impl.h (right): https://codereview.chromium.org/814273005/diff/20001/shell/application_manager/shell_impl.h#newcode5 shell/application_manager/shell_impl.h:5: #ifndef MOJO_APPLICATION_MANAGER_SHELL_IMPL_H_ update these too ./tools/git/mass-rename.sh should take care ...
5 years, 11 months ago (2015-01-15 23:45:51 UTC) #3
ppi
https://codereview.chromium.org/814273005/diff/20001/shell/application_manager/shell_impl.h File shell/application_manager/shell_impl.h (right): https://codereview.chromium.org/814273005/diff/20001/shell/application_manager/shell_impl.h#newcode5 shell/application_manager/shell_impl.h:5: #ifndef MOJO_APPLICATION_MANAGER_SHELL_IMPL_H_ On 2015/01/15 23:45:51, jamesr wrote: > update ...
5 years, 11 months ago (2015-01-15 23:52:30 UTC) #4
jamesr
lgtm
5 years, 11 months ago (2015-01-16 00:02:46 UTC) #5
ppi
5 years, 11 months ago (2015-01-16 00:03:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6384d09bde312ac7915a403f15003137b5268149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698