Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 8142026: Revert 104076 - Change std::wstring to string16 for views::Link (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/compiler_specific.h" 6 #include "base/compiler_specific.h"
7 #include "base/string_util.h" 7 #include "base/string_util.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/extensions/extension_install_dialog.h" 9 #include "chrome/browser/extensions/extension_install_dialog.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 column_set->AddPaddingColumn(0, views::kPanelHorizMargin); 155 column_set->AddPaddingColumn(0, views::kPanelHorizMargin);
156 column_set->AddColumn(GridLayout::LEADING, 156 column_set->AddColumn(GridLayout::LEADING,
157 GridLayout::LEADING, 157 GridLayout::LEADING,
158 0, // no resizing 158 0, // no resizing
159 GridLayout::USE_PREF, 159 GridLayout::USE_PREF,
160 0, // no fixed width 160 0, // no fixed width
161 kIconSize); 161 kIconSize);
162 162
163 layout->StartRow(0, column_set_id); 163 layout->StartRow(0, column_set_id);
164 164
165 views::Label* heading = new views::Label( 165 views::Label* heading = new views::Label(UTF16ToWide(
166 prompt.GetHeading(extension->name())); 166 prompt.GetHeading(extension->name())));
167 heading->SetFont(heading->font().DeriveFont(kHeadingFontSizeDelta, 167 heading->SetFont(heading->font().DeriveFont(kHeadingFontSizeDelta,
168 gfx::Font::BOLD)); 168 gfx::Font::BOLD));
169 heading->SetMultiLine(true); 169 heading->SetMultiLine(true);
170 heading->SetHorizontalAlignment(views::Label::ALIGN_LEFT); 170 heading->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
171 heading->SizeToFit(left_column_width); 171 heading->SizeToFit(left_column_width);
172 layout->AddView(heading); 172 layout->AddView(heading);
173 173
174 // Scale down to icon size, but allow smaller icons (don't scale up). 174 // Scale down to icon size, but allow smaller icons (don't scale up).
175 gfx::Size size(skia_icon->width(), skia_icon->height()); 175 gfx::Size size(skia_icon->width(), skia_icon->height());
176 if (size.width() > kIconSize || size.height() > kIconSize) 176 if (size.width() > kIconSize || size.height() > kIconSize)
(...skipping 15 matching lines...) Expand all
192 layout->AddView(icon, 1, icon_row_span); 192 layout->AddView(icon, 1, icon_row_span);
193 193
194 if (is_inline_install()) { 194 if (is_inline_install()) {
195 layout->StartRow(0, column_set_id); 195 layout->StartRow(0, column_set_id);
196 views::View* rating = new views::View(); 196 views::View* rating = new views::View();
197 rating->SetLayoutManager(new views::BoxLayout( 197 rating->SetLayoutManager(new views::BoxLayout(
198 views::BoxLayout::kHorizontal, 0, 0, 0)); 198 views::BoxLayout::kHorizontal, 0, 0, 0));
199 layout->AddView(rating); 199 layout->AddView(rating);
200 prompt.AppendRatingStars(AddResourceIcon, rating); 200 prompt.AppendRatingStars(AddResourceIcon, rating);
201 201
202 views::Label* rating_count = new views::Label(prompt.GetRatingCount()); 202 views::Label* rating_count = new views::Label(
203 UTF16ToWide(prompt.GetRatingCount()));
203 rating_count->SetFont( 204 rating_count->SetFont(
204 rating_count->font().DeriveFont(kRatingFontSizeDelta)); 205 rating_count->font().DeriveFont(kRatingFontSizeDelta));
205 // Add some space between the stars and the rating count. 206 // Add some space between the stars and the rating count.
206 rating_count->set_border(views::Border::CreateEmptyBorder(0, 2, 0, 0)); 207 rating_count->set_border(views::Border::CreateEmptyBorder(0, 2, 0, 0));
207 rating->AddChildView(rating_count); 208 rating->AddChildView(rating_count);
208 209
209 layout->StartRow(0, column_set_id); 210 layout->StartRow(0, column_set_id);
210 views::Label* user_count = new views::Label(prompt.GetUserCount()); 211 views::Label* user_count = new views::Label(
212 UTF16ToWide(prompt.GetUserCount()));
211 user_count->SetColor(SK_ColorGRAY); 213 user_count->SetColor(SK_ColorGRAY);
212 user_count->SetFont(user_count->font().DeriveFont(kRatingFontSizeDelta)); 214 user_count->SetFont(user_count->font().DeriveFont(kRatingFontSizeDelta));
213 layout->AddView(user_count); 215 layout->AddView(user_count);
214 216
215 layout->StartRow(0, column_set_id); 217 layout->StartRow(0, column_set_id);
216 views::Link* store_link = new views::Link( 218 views::Link* store_link = new views::Link(UTF16ToWide(
217 l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_STORE_LINK)); 219 l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_STORE_LINK)));
218 store_link->SetFont(store_link->font().DeriveFont(kRatingFontSizeDelta)); 220 store_link->SetFont(store_link->font().DeriveFont(kRatingFontSizeDelta));
219 store_link->set_listener(this); 221 store_link->set_listener(this);
220 layout->AddView(store_link); 222 layout->AddView(store_link);
221 } 223 }
222 224
223 if (prompt.GetPermissionCount()) { 225 if (prompt.GetPermissionCount()) {
224 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 226 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
225 227
226 if (is_inline_install()) { 228 if (is_inline_install()) {
227 layout->StartRow(0, column_set_id); 229 layout->StartRow(0, column_set_id);
228 views::Separator* separator = new views::Separator(); 230 views::Separator* separator = new views::Separator();
229 layout->AddView(separator, 3, 1, GridLayout::FILL, GridLayout::FILL); 231 layout->AddView(separator, 3, 1, GridLayout::FILL, GridLayout::FILL);
230 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 232 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
231 } 233 }
232 234
233 layout->StartRow(0, column_set_id); 235 layout->StartRow(0, column_set_id);
234 views::Label* permissions_header = new views::Label( 236 views::Label* permissions_header = new views::Label(UTF16ToWide(
235 prompt.GetPermissionsHeader()); 237 prompt.GetPermissionsHeader()));
236 permissions_header->SetMultiLine(true); 238 permissions_header->SetMultiLine(true);
237 permissions_header->SetHorizontalAlignment(views::Label::ALIGN_LEFT); 239 permissions_header->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
238 permissions_header->SizeToFit(left_column_width); 240 permissions_header->SizeToFit(left_column_width);
239 layout->AddView(permissions_header); 241 layout->AddView(permissions_header);
240 242
241 for (size_t i = 0; i < prompt.GetPermissionCount(); ++i) { 243 for (size_t i = 0; i < prompt.GetPermissionCount(); ++i) {
242 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 244 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
243 layout->StartRow(0, column_set_id); 245 layout->StartRow(0, column_set_id);
244 views::Label* permission_label = new views::Label( 246 views::Label* permission_label = new views::Label(
245 prompt.GetPermission(i)); 247 UTF16ToWide(prompt.GetPermission(i)));
246 permission_label->SetMultiLine(true); 248 permission_label->SetMultiLine(true);
247 permission_label->SetHorizontalAlignment(views::Label::ALIGN_LEFT); 249 permission_label->SetHorizontalAlignment(views::Label::ALIGN_LEFT);
248 permission_label->SizeToFit(left_column_width); 250 permission_label->SizeToFit(left_column_width);
249 layout->AddView(permission_label); 251 layout->AddView(permission_label);
250 } 252 }
251 } 253 }
252 } 254 }
253 255
254 ExtensionInstallDialogView::~ExtensionInstallDialogView() { 256 ExtensionInstallDialogView::~ExtensionInstallDialogView() {
255 } 257 }
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 } 330 }
329 331
330 ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView( 332 ExtensionInstallDialogView* dialog = new ExtensionInstallDialogView(
331 delegate, extension, icon, prompt); 333 delegate, extension, icon, prompt);
332 334
333 views::Widget* window = browser::CreateViewsWindow( 335 views::Widget* window = browser::CreateViewsWindow(
334 browser_window->GetNativeHandle(), dialog); 336 browser_window->GetNativeHandle(), dialog);
335 337
336 window->Show(); 338 window->Show();
337 } 339 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/edit_search_engine_dialog.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698