chrome/renderer/content_settings_observer.cc - Issue 814183002: Record eTLD+1 for pages that show the mixed content shield.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/content_settings_observer.cc

Issue 814183002: Record eTLD+1 for pages that show the mixed content shield. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/tab_specific_content_settings.cc ('K') | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/content_settings_observer.cc

diff --git a/chrome/renderer/content_settings_observer.cc b/chrome/renderer/content_settings_observer.cc

index a9385f1e393e1b8b04618ccb7e58901f3911089e..b5bf35ce2ea0252b6a53de97e38d5488e5c34569 100644

--- a/chrome/renderer/content_settings_observer.cc

+++ b/chrome/renderer/content_settings_observer.cc

@@ -579,7 +579,7 @@ bool ContentSettingsObserver::allowRunningInsecureContent(

SendInsecureContentSignal(INSECURE_CONTENT_RUN_SWF);

if (!allow_running_insecure_content_ && !allowed_per_settings) {

- DidBlockContentType(CONTENT_SETTINGS_TYPE_MIXEDSCRIPT);

+ DidBlockContentType(CONTENT_SETTINGS_TYPE_MIXEDSCRIPT, origin.host());

return false;

}