Record eTLD+1 for pages that show the mixed content shield.

Record eTLD+1 for pages that show the mixed content shield.

BUG=413057
Committed: https://crrev.com/f1c6c03284521aad5a5a5d83bb65dca4c0cbeead
Cr-Commit-Position: refs/heads/master@{#310700}

[lgarron, 2014-12-19 05:31:04]

lgarron@chromium.org changed reviewers:
+ jochen@chromium.org

[lgarron, 2014-12-19 05:31:05]

jochen: If you happen to be in, would you mind reviewing this? (chrome/renderer/
doesn't have an owner, so I need to get someone who owns chrome/ anyhow.)

[lgarron, 2014-12-19 23:41:01]

lgarron@chromium.org changed reviewers:
+ bauerb@chromium.org, thakis@chromium.org
- jochen@chromium.org

[lgarron, 2014-12-19 23:41:01]

bauerb: I can't quite tell if Jochen is in early next week; would you mind
reviewing this?

thakis: chrome/renderer/content_settings_observer.cc has an extra arg. Would you
mind applying the full list of sanity checks?

[Nico, 2014-12-19 23:43:53]

chrome/renderer lgtm

bauerb for the other two files, I suppose.

https://codereview.chromium.org/814183002/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/814183002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.cc:353: // RAPPOR
useless comment

[lgarron, 2014-12-19 23:50:34]

lgarron@chromium.org changed reviewers:
+ isherman@chromium.org

[lgarron, 2014-12-19 23:50:34]

isherman: Would you mind reviewing rappor.xml?

https://codereview.chromium.org/814183002/diff/1/chrome/browser/content_setti...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/814183002/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/tab_specific_content_settings.cc:353: // RAPPOR
On 2014/12/19 23:43:53, Nico wrote:
> useless comment

Done.

[Ilya Sherman, 2014-12-20 00:04:22]

isherman@chromium.org changed reviewers:
+ holte@chromium.org

[Ilya Sherman, 2014-12-20 00:04:23]

Steve is a better reviewer than I am for RAPPOR changes.

[Ilya Sherman, 2014-12-20 00:23:18]

/cc hodie

[Bernhard Bauer, 2014-12-22 11:01:53]

lgtm

[lgarron, 2015-01-07 01:46:16]

hodie, holte: *poke*

It would be nice to land this before the branch cut (Friday).

[Steven Holte, 2015-01-07 18:38:21]

One potential simplification, otherwise LGTM

https://codereview.chromium.org/814183002/diff/20001/chrome/browser/content_s...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/814183002/diff/20001/chrome/browser/content_s...
chrome/browser/content_settings/tab_specific_content_settings.cc:361:
net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
Consider using SampleDomainAndRegistryFromGURL() from
chrome/browser/metrics/rappor/sampling.h

[Ilya Sherman, 2015-01-07 21:30:33]

LGTM

[lgarron, 2015-01-07 21:56:46]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-01-07 21:58:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/814183002/20001

[commit-bot: I haz the power, 2015-01-07 22:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 22:16:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2015-01-09 01:42:46]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-01-09 01:43:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/814183002/40001

[commit-bot: I haz the power, 2015-01-09 03:26:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 03:28:39]

Patchset 3 (id:??) landed as
https://crrev.com/f1c6c03284521aad5a5a5d83bb65dca4c0cbeead
Cr-Commit-Position: refs/heads/master@{#310700}

[lgarron, 2015-03-27 03:57:27]

lgarron@chromium.org changed reviewers:
- bauerb@chromium.org, holte@chromium.org, isherman@chromium.org,
thakis@chromium.org

[lgarron, 2015-03-27 03:57:29]

https://codereview.chromium.org/814183002/diff/20001/chrome/browser/content_s...
File chrome/browser/content_settings/tab_specific_content_settings.cc (right):

https://codereview.chromium.org/814183002/diff/20001/chrome/browser/content_s...
chrome/browser/content_settings/tab_specific_content_settings.cc:361:
net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES));
On 2015/01/07 18:38:21, Steven Holte wrote:
> Consider using SampleDomainAndRegistryFromGURL() from
> chrome/browser/metrics/rappor/sampling.h

Unfortunately, the domain is not available to us as a GURL (neither here nor one
level up). :-(