Issue 814173005: The Sky parser should yield before start tags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 814173005: The Sky parser should yield before start tags (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

The Sky parser should yield before start tags This CL makes the parser yield before non-import start tags if there are outstanding imports. This will let use remove the upgrade path from custom elements because we can require the registration to happen before the tree building. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f990d6d37b72dfb491d7b9f266f258ec31b6027f

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -66 lines)			Patch
M	sky/engine/core/dom/Document.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	sky/engine/core/dom/DocumentParser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/html/parser/BackgroundHTMLParser.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sky/engine/core/html/parser/BackgroundHTMLParser.cpp	View	2 chunks	+14 lines, -1 line	0 comments	Download
M	sky/engine/core/html/parser/HTMLDocumentParser.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	sky/engine/core/html/parser/HTMLDocumentParser.cpp	View	8 chunks	+6 lines, -50 lines	0 comments	Download

Total messages: 3 (0 generated)

eseidel

lgtm It's difficult to tell what this does from this diff view. I agree with ...

5 years, 11 months ago (2015-01-08 22:02:23 UTC) #2

abarth-chromium

5 years, 11 months ago (2015-01-08 22:48:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f990d6d37b72dfb491d7b9f266f258ec31b6027f (presubmit successful).