Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceGlobalInits.h

Issue 814163004: Subzero: Remove the GlobalContext::GlobalDeclarations vector. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove unused GlobalContext args Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceGlobalInits.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceGlobalInits.h
diff --git a/src/IceGlobalInits.h b/src/IceGlobalInits.h
index 082be3c37c0f63ae4b505c0b53ff7962560d0e39..0d560a12304876753b34ad922a9432a75469f9a5 100644
--- a/src/IceGlobalInits.h
+++ b/src/IceGlobalInits.h
@@ -91,11 +91,9 @@ protected:
class FunctionDeclaration : public GlobalDeclaration {
FunctionDeclaration(const FunctionDeclaration &) = delete;
FunctionDeclaration &operator=(const FunctionDeclaration &) = delete;
- friend class GlobalContext;
public:
- static FunctionDeclaration *create(GlobalContext *Ctx,
- const FuncSigType &Signature,
+ static FunctionDeclaration *create(const FuncSigType &Signature,
llvm::CallingConv::ID CallingConv,
llvm::GlobalValue::LinkageTypes Linkage,
bool IsProto);
@@ -129,10 +127,6 @@ private:
class VariableDeclaration : public GlobalDeclaration {
VariableDeclaration(const VariableDeclaration &) = delete;
VariableDeclaration &operator=(const VariableDeclaration &) = delete;
- friend class GlobalContext;
- // TODO(kschimpf) Factor out allocation of initializers into the
- // global context, so that memory allocation/collection can be
- // optimized.
public:
/// Base class for a global variable initializer.
class Initializer {
@@ -248,7 +242,7 @@ public:
/// Models the list of initializers.
typedef std::vector<Initializer *> InitializerListType;
- static VariableDeclaration *create(GlobalContext *Ctx);
+ static VariableDeclaration *create();
~VariableDeclaration() final;
const InitializerListType &getInitializers() const { return Initializers; }
« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceGlobalInits.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698