Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 814163002: Revert of Enable display list 2D canvas by default (Closed)

Created:
6 years ago by fmeawad
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable display list 2D canvas by default (patchset #1 id:1 of https://codereview.chromium.org/818443002/) Reason for revert: Speculative revert. Causing blink_perf.canvas to fail on Linux and Mac http://build.chromium.org/p/chromium.perf/builders/Mac%2010.8%20Perf%20%281%29/builds/1403 http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/4504 Original issue's description: > Enable display list 2D canvas by default > > With this change, display list 2D canvas will become enabled by > default in Chrome. Content shell with --dump-render-tree will > continue to have display lists disabled by default. > Currently, having display lists enabled in blink means > that display lists will be used whenever 2d canvases would > not be GPU-accelerated. > > BUG=386601 > > Committed: https://crrev.com/f98a302c6231cd607bb64eeadc5233ca858e3e8e > Cr-Commit-Position: refs/heads/master@{#309069} TBR=avi@chromium.org,junov@chromium.org NOTREECHECKS=true NOTRY=true BUG=386601, 443825 Committed: https://crrev.com/d5969b74ddd583114021790f23774946be2eae58 Cr-Commit-Position: refs/heads/master@{#309119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/child/runtime_features.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fmeawad
Created Revert of Enable display list 2D canvas by default
6 years ago (2014-12-19 00:51:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814163002/1
6 years ago (2014-12-19 00:52:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 00:53:40 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-19 00:54:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5969b74ddd583114021790f23774946be2eae58
Cr-Commit-Position: refs/heads/master@{#309119}

Powered by Google App Engine
This is Rietveld 408576698