Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 814153003: Revert of Revert of Clean up Smart Lock cryptohome keys logic: (Closed)

Created:
6 years ago by benwells
Modified:
6 years ago
Reviewers:
xiyuan, Tim Song, tbarzic
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Clean up Smart Lock cryptohome keys logic: (patchset #1 id:1 of https://codereview.chromium.org/789793005/) Reason for revert: This didn't fix the problem, so reverting the revert. Original issue's description: > Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/) > > Reason for revert: > Once this change landed chromeos file manager tests started failing across the MSAN bots. > > This is the most likely culprit, so reverting speculatively. If this does not help will reland this change. > > See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139 > > Original issue's description: > > Clean up Smart Lock cryptohome keys logic: > > > > 1. Queue all cryptohome keys operations. > > 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices > > 3. Introduce new RefreshKeys operation using the existing add and remove keys > > operations to replace the current cryptohome keys with new keys. > > 4. After reauthenticating for setup, remove the old cryptohome keys. > > > > BUG=432996 > > > > Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa > > Cr-Commit-Position: refs/heads/master@{#309094} > > TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=432996 > > Committed: https://crrev.com/8ffa00af2d4e322e91859c502aa02e0c9b0e1f2a > Cr-Commit-Position: refs/heads/master@{#309519} TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org NOTREECHECKS=true NOTRY=true BUG=432996 Committed: https://crrev.com/a41e4ab37d11f2a5ecdebdf184138eb99eeaa31e Cr-Commit-Position: refs/heads/master@{#309540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -198 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h View 5 chunks +28 lines, -32 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc View 4 chunks +35 lines, -100 lines 0 comments Download
A chrome/browser/chromeos/login/easy_unlock/easy_unlock_refresh_keys_operation.h View 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/easy_unlock/easy_unlock_refresh_keys_operation.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 3 chunks +35 lines, -29 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Revert of Clean up Smart Lock cryptohome keys logic:
6 years ago (2014-12-23 06:34:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814153003/1
6 years ago (2014-12-23 06:35:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 06:36:35 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-23 06:37:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a41e4ab37d11f2a5ecdebdf184138eb99eeaa31e
Cr-Commit-Position: refs/heads/master@{#309540}

Powered by Google App Engine
This is Rietveld 408576698