DescriptionRevert of Revert of Clean up Smart Lock cryptohome keys logic: (patchset #1 id:1 of https://codereview.chromium.org/789793005/)
Reason for revert:
This didn't fix the problem, so reverting the revert.
Original issue's description:
> Revert of Clean up Smart Lock cryptohome keys logic: (patchset #5 id:80001 of https://codereview.chromium.org/808563004/)
>
> Reason for revert:
> Once this change landed chromeos file manager tests started failing across the MSAN bots.
>
> This is the most likely culprit, so reverting speculatively. If this does not help will reland this change.
>
> See http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Browser%20%282%29/builds/139
>
> Original issue's description:
> > Clean up Smart Lock cryptohome keys logic:
> >
> > 1. Queue all cryptohome keys operations.
> > 2. Roll ClearRemoteDevices as a specific case of SetRemoteDevices
> > 3. Introduce new RefreshKeys operation using the existing add and remove keys
> > operations to replace the current cryptohome keys with new keys.
> > 4. After reauthenticating for setup, remove the old cryptohome keys.
> >
> > BUG=432996
> >
> > Committed: https://crrev.com/275152c34d8edc5346757288cfffe63444650faa
> > Cr-Commit-Position: refs/heads/master@{#309094}
>
> TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=432996
>
> Committed: https://crrev.com/8ffa00af2d4e322e91859c502aa02e0c9b0e1f2a
> Cr-Commit-Position: refs/heads/master@{#309519}
TBR=tbarzic@chromium.org,xiyuan@chromium.org,tengs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432996
Committed: https://crrev.com/a41e4ab37d11f2a5ecdebdf184138eb99eeaa31e
Cr-Commit-Position: refs/heads/master@{#309540}
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|