Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 814123003: Add handling for Skia's SkPath::intersect's return value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed braces Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/renderer/test_runner/mock_web_theme_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab.cc
diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc
index 680d3e6462764e3595edfbf9aa514f50991c05fc..29841163c87a34db0b811cabbf7030e9156b44aa 100644
--- a/chrome/browser/ui/views/tabs/tab.cc
+++ b/chrome/browser/ui/views/tabs/tab.cc
@@ -710,11 +710,11 @@ bool Tab::GetHitTestMask(gfx::Path* mask) const {
controller_->ShouldPaintTab(this, &clip);
if (clip.size().GetArea()) {
SkRect intersection(mask->getBounds());
- intersection.intersect(RectToSkRect(clip));
mask->reset();
+ if (!intersection.intersect(RectToSkRect(clip)))
+ return false;
mask->addRect(intersection);
}
-
return true;
}
« no previous file with comments | « no previous file | content/shell/renderer/test_runner/mock_web_theme_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698