Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 814113008: Make virtual/regionbasedmulticol/fast/multicol/newmulticol/balance-maxheight2.html pass on Mac. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make virtual/regionbasedmulticol/fast/multicol/newmulticol/balance-maxheight2.html pass on Mac. Remove the platform expectation file, and make sure that it renders correctly instead. Setting line-height explicitly solved the problem. BUG=447492 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188146

Patch Set 1 #

Patch Set 2 : rebase master #

Patch Set 3 : virtual/slimmingpaint/fast/multicol/newmulticol/balance-maxheight2.html should pass now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/newmulticol/balance-maxheight2.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/regionbasedmulticol/fast/multicol/newmulticol/balance-maxheight2-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-09 10:41:02 UTC) #1
andersr
lgtm
5 years, 11 months ago (2015-01-09 10:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814113008/40001
5 years, 11 months ago (2015-01-09 12:10:00 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 13:17:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188146

Powered by Google App Engine
This is Rietveld 408576698