Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 814113007: [fsp] Do not close files which failed to open for reading and writing. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Do not close files which failed to open for reading and writing. This CL fixes the logic for detecting if a file was correctly opened in the fsp::FileStreamReader and fsp::FileStreamWriter classes. TEST=browser_test: *FileSystemProvider*, unit_test: *FileSystemProvider*FileStream* BUG=447448 Committed: https://crrev.com/8b8e1fac50acf7f2245b96b1f30353fb41ac8de8 Cr-Commit-Position: refs/heads/master@{#310713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@yawano: PTAL. Thanks!
5 years, 11 months ago (2015-01-09 04:21:36 UTC) #2
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-09 04:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814113007/1
5 years, 11 months ago (2015-01-09 04:58:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 05:05:38 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 05:06:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b8e1fac50acf7f2245b96b1f30353fb41ac8de8
Cr-Commit-Position: refs/heads/master@{#310713}

Powered by Google App Engine
This is Rietveld 408576698