Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp

Issue 814083003: Update animation when changes in animation keyframes are detected. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase + Address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/resolver/ScopedStyleResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
diff --git a/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp b/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
index 0d4885bb3cd7bc22074bcf6d6ef44863c96884df..adbc58ba801ce3b82f76c74d9bee2bb822c019f8 100644
--- a/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
+++ b/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp
@@ -113,7 +113,6 @@ static bool ruleAdditionMightRequireDocumentStyleRecalc(StyleRuleBase* rule)
// the added @rule can't require style recalcs.
switch (rule->type()) {
case StyleRule::Import: // Whatever we import should do its own analysis, we don't need to invalidate the document here!
- case StyleRule::Keyframes: // Keyframes never cause style invalidations and are handled during sheet insertion.
case StyleRule::Page: // Page rules apply only during printing, we force a full-recalc before printing.
return false;
@@ -121,6 +120,7 @@ static bool ruleAdditionMightRequireDocumentStyleRecalc(StyleRuleBase* rule)
case StyleRule::FontFace: // If the fonts aren't in use, we could avoid recalc.
case StyleRule::Supports: // If we evaluated the supports-clause we could avoid recalc.
case StyleRule::Viewport: // If the viewport doesn't match, we could avoid recalcing.
+ case StyleRule::Keyframes: // If the animation doesn't match an element, we could avoid recalc.
// FIXME: Unclear if any of the rest need to cause style recalc:
case StyleRule::Filter:
return true;
« no previous file with comments | « Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | Source/core/css/resolver/ScopedStyleResolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698