Issue 814043002: Revert of [turbofan] remove control field from instruction

Issue 814043002: Revert of [turbofan] remove control field from instruction (Closed)

Created:
6 years ago by Michael Achenbach

Modified:
6 years ago

Reviewers:
titzer, dcarney

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [turbofan] remove control field from instruction (patchset #1 id:1 of https://codereview.chromium.org/810023002/) Reason for revert: Needed to revert https://chromium.googlesource.com/v8/v8/+/70b5eb47b39acbf31746f4a116a9b3ce2730218a Original issue's description: > [turbofan] remove control field from instruction > > R=titzer@chromium.org > BUG= > > Committed: https://crrev.com/7b9cb2eb3764d0c807c669e397fc3b84fbefb175 > Cr-Commit-Position: refs/heads/master@{#25866} TBR=titzer@chromium.org,dcarney@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/70eb456e731ce01c2aa2203d8a6ea459fa8b41ba Cr-Commit-Position: refs/heads/master@{#25884}

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -47 lines)			Patch
M	src/compiler/arm/instruction-selector-arm.cc	View	5 chunks	+12 lines, -8 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View	5 chunks	+10 lines, -6 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/compiler/instruction.h	View	5 chunks	+12 lines, -3 lines	0 comments	Download
M	src/compiler/instruction-selector.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/mips/instruction-selector-mips.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/compiler/mips64/instruction-selector-mips64.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/compiler/register-allocator.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/cctest/compiler/test-instruction.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/compiler/test-jump-threading.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	test/unittests/compiler/instruction-sequence-unittest.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of [turbofan] remove control field from instruction

6 years ago (2014-12-18 14:41:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814043002/1

6 years ago (2014-12-18 14:42:00 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-18 18:05:31 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/70eb456e731ce01c2aa2203d8a6ea459fa8b41ba
Cr-Commit-Position: refs/heads/master@{#25884}