net/spdy/spdy_session.cc - Issue 813993002: Fix crash in handling PushStreams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 813993002: Fix crash in handling PushStreams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix crash in handling PushStreams Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index a2e239e18b6b824c29a5e6b781ac722bccf7bd38..f2fb8b4536c8f691f470f21d2b65c25d2480c657 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -2703,12 +2703,12 @@ bool SpdySession::TryCreatePushStream(SpdyStreamId stream_id,

last_compressed_frame_len_ = 0;

- DeleteExpiredPushedStreams();

PushedStreamMap::iterator inserted_pushed_it =

unclaimed_pushed_streams_.insert(

pushed_it,

std::make_pair(gurl, PushedStreamInfo(stream_id, time_func_())));

DCHECK(inserted_pushed_it != pushed_it);

+ DeleteExpiredPushedStreams();

InsertActivatedStream(stream.Pass());

« no previous file with comments | « no previous file | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »