Fix crash in handling PushStreams

net/spdy/spdy_session.cc

Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a2e239e18b6b824c29a5e6b781ac722bccf7bd38..f2fb8b4536c8f691f470f21d2b65c25d2480c657 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -2703,12 +2703,12 @@ bool SpdySession::TryCreatePushStream(SpdyStreamId stream_id,
 
   last_compressed_frame_len_ = 0;
 
-  DeleteExpiredPushedStreams();

[szym, 2014/12/18 06:34:38]

This is definitely a bug and the solution makes sense to me.

The only thing that I'd ask for is a unit test to cover this situation.

[Ryan Hamilton, 2015/01/07 19:32:14]

+1 for a test.

   PushedStreamMap::iterator inserted_pushed_it =
       unclaimed_pushed_streams_.insert(
           pushed_it,
           std::make_pair(gurl, PushedStreamInfo(stream_id, time_func_())));
   DCHECK(inserted_pushed_it != pushed_it);
+  DeleteExpiredPushedStreams();
 
   InsertActivatedStream(stream.Pass());