Source/platform/image-decoders/gif/GIFImageReader.h - Issue 813943003: Fix handling of broken GIFs with weird frame sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/image-decoders/gif/GIFImageReader.h

Issue 813943003: Fix handling of broken GIFs with weird frame sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp ('K') | « Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp ('k') | Source/platform/image-decoders/gif/GIFImageReader.cpp » ('j') | Source/platform/image-decoders/gif/GIFImageReader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/image-decoders/gif/GIFImageReader.h

diff --git a/Source/platform/image-decoders/gif/GIFImageReader.h b/Source/platform/image-decoders/gif/GIFImageReader.h

index 366a2cef1c9d501fabc98dcc9af687feb4973505..5d195e30af6c09f6b08ed400c57f0f1f94c78338 100644

--- a/Source/platform/image-decoders/gif/GIFImageReader.h

+++ b/Source/platform/image-decoders/gif/GIFImageReader.h

@@ -286,6 +286,7 @@ public:

, m_version(0)

, m_screenWidth(0)

, m_screenHeight(0)

+ , m_sizeFinal(false)

, m_loopCount(cLoopCountNotSeen)

, m_parseCompleted(false)

{

@@ -351,6 +352,7 @@ private:

int m_version; // Either 89 for GIF89 or 87 for GIF87.

unsigned m_screenWidth; // Logical screen width & height.

unsigned m_screenHeight;

+ bool m_sizeFinal;

Peter Kasting 2015/01/08 06:56:18 Nit: Please comment about what this means. I migh

Alpha Left Google 2015/01/12 22:12:49 Done.

GIFColorMap m_globalColorMap;

int m_loopCount; // Netscape specific extension block to control the number of animation loops a GIF renders.