Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813903002: replace COMPILE_ASSERT with static_assert in modules/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in modules/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187464

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/modules/crypto/CryptoKey.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@Mike: PTAL.
6 years ago (2014-12-17 22:10:08 UTC) #2
Mike West
\o/ LGTM.
6 years ago (2014-12-18 12:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813903002/1
6 years ago (2014-12-18 12:54:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/87954)
6 years ago (2014-12-18 13:53:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813903002/20001
6 years ago (2014-12-18 14:23:12 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-18 15:32:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187464

Powered by Google App Engine
This is Rietveld 408576698