Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813883002: replace COMPILE_ASSERT with static_assert in platform/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Nico
CC:
blink-reviews, shans, eae+blinkwatch, leviw+bidiwatch_chromium.org, Steve Block, rwlbuis, krit, blink-reviews-events_chromium.org, dglazkov+blink, danakj, dstockwell, Timothy Loh, Rik, Eric Willigers, rjwright, Mads Ager (chromium), jbroman, Dominik Röttsches, pdr+graphicswatchlist_chromium.org, darktears, haraken, blink-reviews-animation_chromium.org, Mike Lawther (Google), f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in platform/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187415

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : another fixup #

Total comments: 12

Patch Set 4 : final fixups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -135 lines) Patch
M Source/platform/CrossThreadCopier.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/CrossThreadCopier.cpp View 1 2 2 chunks +41 lines, -41 lines 0 comments Download
M Source/platform/EventTracer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/JSONValues.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/Length.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODFreeListArena.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/WebThread.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/animation/AnimationUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebCryptoAlgorithm.cpp View 1 2 3 1 chunk +16 lines, -16 lines 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontWidthVariant.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/platform/geometry/Region.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/heap/Handle.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/heap/Heap.h View 1 8 chunks +10 lines, -8 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 chunk +16 lines, -16 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 6 chunks +17 lines, -17 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/BidiContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextBreakIterator.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/text/TextRun.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Nico: PTAL (I'm getting close to being able to remove COMPILE_ASSERT from blink now).
6 years ago (2014-12-17 23:13:40 UTC) #2
Nico
lgtm https://codereview.chromium.org/813883002/diff/40001/Source/platform/CrossThreadCopier.h File Source/platform/CrossThreadCopier.h (right): https://codereview.chromium.org/813883002/diff/40001/Source/platform/CrossThreadCopier.h#newcode88 Source/platform/CrossThreadCopier.h:88: "Only one type modification should be allowed"); nit: ...
6 years ago (2014-12-17 23:24:44 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/813883002/diff/40001/Source/platform/CrossThreadCopier.h File Source/platform/CrossThreadCopier.h (right): https://codereview.chromium.org/813883002/diff/40001/Source/platform/CrossThreadCopier.h#newcode88 Source/platform/CrossThreadCopier.h:88: "Only one type modification should be allowed"); On 2014/12/17 ...
6 years ago (2014-12-17 23:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813883002/60001
6 years ago (2014-12-17 23:35:15 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 01:55:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187415

Powered by Google App Engine
This is Rietveld 408576698