Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 813873007: Fix debug-debugger.js wrt strict mode. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix debug-debugger.js wrt strict mode. R=rossberg@chromium.org BUG=v8:3790 LOG=N Committed: https://crrev.com/10a58904ac845cf97c21116c1d13d61e1afe8f34 Cr-Commit-Position: refs/heads/master@{#25971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/debug-debugger.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 11 months ago (2015-01-07 09:56:04 UTC) #1
rossberg
lgtm
5 years, 11 months ago (2015-01-07 12:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813873007/1
5 years, 11 months ago (2015-01-07 12:41:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 13:08:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10a58904ac845cf97c21116c1d13d61e1afe8f34 Cr-Commit-Position: refs/heads/master@{#25971}
5 years, 11 months ago (2015-01-07 13:08:32 UTC) #6
noordhuis
On 2015/01/07 13:08:32, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 11 months ago (2015-01-18 17:17:44 UTC) #7
Yang
5 years, 11 months ago (2015-01-19 07:33:48 UTC) #8
Message was sent while issue was closed.
On 2015/01/18 17:17:44, info1 wrote:
> On 2015/01/07 13:08:32, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/10a58904ac845cf97c21116c1d13d61e1afe8f34
> > Cr-Commit-Position: refs/heads/master@{#25971}
> 
> Yang, could this fix be back-ported to the 4.1 branch?  Thanks!

Back merged to 4.1.0.8

Powered by Google App Engine
This is Rietveld 408576698