Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: chrome/browser/about_flags.cc

Issue 813873005: Add field trial and flag to mark HTTP as non-secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename to "Mark Non-Secure As ...", use named constants. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 6a15037a89c372c9ca6a80a6712566838d52e670..61b12e8980c0d395d3cb08c7c105baea4dc3deda 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -188,6 +188,15 @@ const Experiment::Choice kNaClDebugMaskChoices[] = {
};
#endif
+const Experiment::Choice kMarkNonSecureAsChoices[] = {
+ { IDS_MARK_NON_SECURE_AS_NEUTRAL,
+ switches::kMarkNonSecureAs, switches::kMarkNonSecureAsNeutral},
+ { IDS_MARK_NON_SECURE_AS_NON_SECURE,
+ switches::kMarkNonSecureAs, switches::kMarkNonSecureAsNonSecure},
+ { IDS_MARK_NON_SECURE_AS_DUBIOUS,
+ switches::kMarkNonSecureAs, switches::kMarkNonSecureAsDubious}
+};
+
const Experiment::Choice kMaxTilesForInterestAreaChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT,
@@ -2120,6 +2129,14 @@ const Experiment kExperiments[] = {
SINGLE_VALUE_TYPE(switches::kEnableDelayAgnosticAec)
},
+ {
+ "mark-http-as-non-secure", // FLAGS:RECORD_UMA
+ IDS_MARK_NON_SECURE_AS_NAME,
+ IDS_MARK_NON_SECURE_AS_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)
+ },
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698