Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4478)

Unified Diff: chrome/browser/about_flags.cc

Issue 813873005: Add field trial and flag to mark HTTP as non-secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/counter/action/ Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 713f97b545ee5e6ce29fecefc0bb3579436fe104..302200194f71692182a93143a0b65fbd2a9288a8 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -188,6 +188,15 @@ const Experiment::Choice kNaClDebugMaskChoices[] = {
};
#endif
+const Experiment::Choice kMarkHttpAsNonSecureChoices[] = {
+ { IDS_MARK_HTTP_AS_NON_SECURE_CHOICE_NO,
+ switches::kMarkHttpAsNonSecure, "no"},
+ { IDS_MARK_HTTP_AS_NON_SECURE_CHOICE_NON_SECURE,
+ switches::kMarkHttpAsNonSecure, "non-secure"},
+ { IDS_MARK_HTTP_AS_NON_SECURE_CHOICE_DUBIOUS,
+ switches::kMarkHttpAsNonSecure, "dubious"}
+};
+
const Experiment::Choice kMaxTilesForInterestAreaChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT,
@@ -2106,6 +2115,14 @@ const Experiment kExperiments[] = {
},
#endif
+ {
+ "mark-http-as-non-secure", // FLAGS:RECORD_UMA
+ IDS_MARK_HTTP_AS_NON_SECURE_NAME,
+ IDS_MARK_HTTP_AS_NON_SECURE_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kMarkHttpAsNonSecureChoices)
+ },
+
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698