Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 813873005: Add field trial and flag to mark HTTP as non-secure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Gotta have a default option. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 // so by default we want to avoid debugging that. 181 // so by default we want to avoid debugging that.
182 // NOTE: As the default value must be the empty string, the mask excluding 182 // NOTE: As the default value must be the empty string, the mask excluding
183 // the PNaCl translator and secure shell is substituted elsewhere. 183 // the PNaCl translator and secure shell is substituted elsewhere.
184 { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS_PNACL, "", "" }, 184 { IDS_NACL_DEBUG_MASK_CHOICE_EXCLUDE_UTILS_PNACL, "", "" },
185 { IDS_NACL_DEBUG_MASK_CHOICE_DEBUG_ALL, switches::kNaClDebugMask, "*://*" }, 185 { IDS_NACL_DEBUG_MASK_CHOICE_DEBUG_ALL, switches::kNaClDebugMask, "*://*" },
186 { IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG, 186 { IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG,
187 switches::kNaClDebugMask, "*://*/*debug.nmf" } 187 switches::kNaClDebugMask, "*://*/*debug.nmf" }
188 }; 188 };
189 #endif 189 #endif
190 190
191 const Experiment::Choice kMarkNonSecureAsChoices[] = {
192 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
193 { IDS_MARK_NON_SECURE_AS_NEUTRAL,
194 switches::kMarkNonSecureAs, switches::kMarkNonSecureAsNeutral},
195 { IDS_MARK_NON_SECURE_AS_NON_SECURE,
196 switches::kMarkNonSecureAs, switches::kMarkNonSecureAsNonSecure},
197 { IDS_MARK_NON_SECURE_AS_DUBIOUS,
198 switches::kMarkNonSecureAs, switches::kMarkNonSecureAsDubious}
199 };
200
191 const Experiment::Choice kMaxTilesForInterestAreaChoices[] = { 201 const Experiment::Choice kMaxTilesForInterestAreaChoices[] = {
192 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 202 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
193 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT, 203 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT,
194 cc::switches::kMaxTilesForInterestArea, "64"}, 204 cc::switches::kMaxTilesForInterestArea, "64"},
195 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_TALL, 205 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_TALL,
196 cc::switches::kMaxTilesForInterestArea, "128"}, 206 cc::switches::kMaxTilesForInterestArea, "128"},
197 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_GRANDE, 207 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_GRANDE,
198 cc::switches::kMaxTilesForInterestArea, "256"}, 208 cc::switches::kMaxTilesForInterestArea, "256"},
199 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_VENTI, 209 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_VENTI,
200 cc::switches::kMaxTilesForInterestArea, "512"} 210 cc::switches::kMaxTilesForInterestArea, "512"}
(...skipping 1947 matching lines...) Expand 10 before | Expand all | Expand 10 after
2148 }, 2158 },
2149 #endif 2159 #endif
2150 { 2160 {
2151 "enable-delay-agnostic-aec", 2161 "enable-delay-agnostic-aec",
2152 IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_NAME, 2162 IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_NAME,
2153 IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_DESCRIPTION, 2163 IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_DESCRIPTION,
2154 kOsDesktop, 2164 kOsDesktop,
2155 SINGLE_VALUE_TYPE(switches::kEnableDelayAgnosticAec) 2165 SINGLE_VALUE_TYPE(switches::kEnableDelayAgnosticAec)
2156 }, 2166 },
2157 2167
2168 {
2169 "mark-non-secure-as", // FLAGS:RECORD_UMA
2170 IDS_MARK_NON_SECURE_AS_NAME,
2171 IDS_MARK_NON_SECURE_AS_DESCRIPTION,
2172 kOsAll,
2173 MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)
2174 },
2175
2158 // NOTE: Adding new command-line switches requires adding corresponding 2176 // NOTE: Adding new command-line switches requires adding corresponding
2159 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2177 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2160 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2178 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2161 }; 2179 };
2162 2180
2163 const Experiment* experiments = kExperiments; 2181 const Experiment* experiments = kExperiments;
2164 size_t num_experiments = arraysize(kExperiments); 2182 size_t num_experiments = arraysize(kExperiments);
2165 2183
2166 // Stores and encapsulates the little state that about:flags has. 2184 // Stores and encapsulates the little state that about:flags has.
2167 class FlagsState { 2185 class FlagsState {
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
2726 } 2744 }
2727 2745
2728 const Experiment* GetExperiments(size_t* count) { 2746 const Experiment* GetExperiments(size_t* count) {
2729 *count = num_experiments; 2747 *count = num_experiments;
2730 return experiments; 2748 return experiments;
2731 } 2749 }
2732 2750
2733 } // namespace testing 2751 } // namespace testing
2734 2752
2735 } // namespace about_flags 2753 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698