win: Add Scoped...Handle

util/win/scoped_handle.h

+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_UTIL_WIN_SCOPED_HANDLE_H

[Mark Mentovai, 2014/12/17 22:45:00]

Needs a trailing _.

[scottmg, 2014/12/17 22:57:35]

Done.

+#define CRASHPAD_UTIL_WIN_SCOPED_HANDLE_H
+
+#include <windows.h>
+
+#include "base/scoped_generic.h"
+
+namespace crashpad {
+
+namespace internal {
+
+struct ScopedKernelHandleCloseTraits {
+  static HANDLE InvalidValue() {
+    return nullptr;
+  }
+  static void Free(HANDLE handle);
+};
+
+struct ScopedFileHandleCloseTraits {
+  static HANDLE InvalidValue() {
+    return INVALID_HANDLE_VALUE;
+  }
+  static void Free(HANDLE handle);
+};
+
+}  // namespace internal
+
+using ScopedKernelHandle =
+    base::ScopedGeneric<HANDLE, internal::ScopedKernelHandleCloseTraits>;
+using ScopedFileHandle =

[Mark Mentovai, 2014/12/17 22:45:00]

These names may not fully convey their Windows API-ness. Since they’re not
namespaced, if I saw them in some random code, I don’t know if I’d immediately
make the connection that a “scoped file handle” was a Windows HANDLE.

ScopedFileHANDLE? ScopedWinFileHandle?

[scottmg, 2014/12/17 22:57:35]

Maybe win::ScopedFileHandle is better? (is closer to base/) Also happy to
s/Handle/HANDLE/, it just seemed a bit screamy. On the other hand, there is a
ScopedFILE in base, so I guess either has precedent.

+    base::ScopedGeneric<HANDLE, internal::ScopedFileHandleCloseTraits>;
+
+}  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_WIN_SCOPED_HANDLE_H