Allow build under GTK+ 2.24.

Allow build under GTK+ 2.24.

Some parts of libgtk2ui use newer function and #define names than what's in
GTK+ 2.24, which is what ships with RHEL/CentOS 6.6. This commit allows
Chromium to work on RHEL/CentOS 6.6 by checking for the appropriate GTK version
and using the appropriate API.

This is the same as the already reviewed issue 806843004, just submitted from
the correct email address.
https://codereview.chromium.org/806843004/

BUG=443005
R=erg@chromium.org

Committed: https://crrev.com/5cd198a55b73f7f32e5e8225aa6d8ac0bc39a2fb
Cr-Commit-Position: refs/heads/master@{#308883}

Committed: https://crrev.com/596a1f47709b681f764ab1dcd200d6d18fad3a32
Cr-Commit-Position: refs/heads/master@{#308957}

[Elliot Glaysher, 2014-12-17 22:19:31]

slgtm

[Elliot Glaysher, 2014-12-17 22:19:53]

On 2014/12/17 22:19:31, Elliot Glaysher wrote:
> slgtm

lgtm (the regex appears to not be that smart)

[ian.scott, 2014-12-17 22:24:20]

The CQ bit was checked by ian.scott@arteris.com

[commit-bot: I haz the power, 2014-12-17 22:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813823003/1

[commit-bot: I haz the power, 2014-12-17 23:53:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-17 23:54:38]

Patchset 1 (id:??) landed as
https://crrev.com/5cd198a55b73f7f32e5e8225aa6d8ac0bc39a2fb
Cr-Commit-Position: refs/heads/master@{#308883}

[Kunihiko Sakamoto, 2014-12-18 03:01:18]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/814723002/ by ksakamoto@chromium.org.

The reason for reverting is: broke GoogleChrome Linux Build
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/...

FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
ia32 -c stable
dpkg-shlibdeps: warning: binaries to analyze should already be installed in
their package's directory.
13c13
< libglib2.0-0 (>= 2.28.0)
---
> libglib2.0-0 (>= 2.26.0)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32
chrome/installer/linux/debian/expected_deps_x64


Probably you need to change those expected_deps files too.
.

[Lei Zhang, 2014-12-18 04:21:59]

On 2014/12/18 03:01:18, Kunihiko Sakamoto wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/814723002/ by mailto:ksakamoto@chromium.org.
> 
> The reason for reverting is: broke GoogleChrome Linux Build
>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/...
> 
> FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
> ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release -a
> ia32 -c stable
> dpkg-shlibdeps: warning: binaries to analyze should already be installed in
> their package's directory.
> 13c13
> < libglib2.0-0 (>= 2.28.0)
> ---
> > libglib2.0-0 (>= 2.26.0)
> 
> ERROR: Shared library dependencies changed!
> If this is intentional, please update:
> chrome/installer/linux/debian/expected_deps_ia32
> chrome/installer/linux/debian/expected_deps_x64
> 
> 
> Probably you need to change those expected_deps files too.
> .

Just upload a new patch set with the updated expected_deps changes. I will
happily approve it.

[ian.scott, 2014-12-18 05:03:58]

On 2014/12/18 04:21:59, Lei Zhang wrote:
> On 2014/12/18 03:01:18, Kunihiko Sakamoto wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/814723002/ by mailto:ksakamoto@chromium.org.
> > 
> > The reason for reverting is: broke GoogleChrome Linux Build
> >
>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/...
> > 
> > FAILED: cd ../../chrome; flock -- /tmp/linux_package_lock bash
> > ../out/Release/installer/debian/build.sh -o../out/Release -b ../out/Release
-a
> > ia32 -c stable
> > dpkg-shlibdeps: warning: binaries to analyze should already be installed in
> > their package's directory.
> > 13c13
> > < libglib2.0-0 (>= 2.28.0)
> > ---
> > > libglib2.0-0 (>= 2.26.0)
> > 
> > ERROR: Shared library dependencies changed!
> > If this is intentional, please update:
> > chrome/installer/linux/debian/expected_deps_ia32
> > chrome/installer/linux/debian/expected_deps_x64
> > 
> > 
> > Probably you need to change those expected_deps files too.
> > .
> 
> Just upload a new patch set with the updated expected_deps changes. I will
> happily approve it.

Thanks, PTAL.

[Lei Zhang, 2014-12-18 05:42:12]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2014-12-18 05:42:12]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2014-12-18 05:42:13]

lgtm

[commit-bot: I haz the power, 2014-12-18 05:42:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813823003/20001

[commit-bot: I haz the power, 2014-12-18 06:22:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-18 06:23:10]

Patchset 2 (id:??) landed as
https://crrev.com/596a1f47709b681f764ab1dcd200d6d18fad3a32
Cr-Commit-Position: refs/heads/master@{#308957}