Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 813813003: Revert of Remove obsolete V8_INFINITY macro. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove obsolete V8_INFINITY macro. (patchset #3 id:40001 of https://codereview.chromium.org/798413003/) Reason for revert: Speculative revert. This seems to block the current roll: https://codereview.chromium.org/819653003/ I retried several times, also with a new roll. The error is internal - but that doesn't make much of a difference. Original issue's description: > Remove obsolete V8_INFINITY macro. > > Use std::numeric_limits consistently. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/31c66e2d53569c4e229d55483d28208491e73612 > Cr-Commit-Position: refs/heads/master@{#25897} TBR=svenpanne@chromium.org,bmeurer@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7d478d96211d0c8ce5cbe1b9cb2e8720314811a0 Cr-Commit-Position: refs/heads/master@{#25912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -318 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/assembler.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 8 chunks +12 lines, -21 lines 0 comments Download
M src/conversions-inl.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/globals.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/strtod.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/types.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +17 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-typer.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 2 chunks +11 lines, -12 lines 0 comments Download
M test/cctest/test-assembler-arm64.cc View 5 chunks +89 lines, -94 lines 0 comments Download
M test/cctest/test-checks.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-double.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M test/cctest/test-strtod.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +4 lines, -8 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
Created Revert of Remove obsolete V8_INFINITY macro.
6 years ago (2014-12-20 13:11:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813813003/1
6 years ago (2014-12-20 13:11:58 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/mips/code-stubs-mips.cc: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-20 13:12:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813813003/1
6 years ago (2014-12-20 13:17:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 13:17:28 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-20 13:17:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d478d96211d0c8ce5cbe1b9cb2e8720314811a0
Cr-Commit-Position: refs/heads/master@{#25912}

Powered by Google App Engine
This is Rietveld 408576698