Service Worker: Improve some exception messages (Chromium).

Service Worker: Improve some exception messages (Chromium).

- Prefix the error messages to indicate the operation
that failed (particularly helps when the error occurs
in a promise chain)
- Add more details to the error messages.

Example improvements:

Before: "URL too long"
After: "Failed to register a ServiceWorker: The
provided scriptURL or scope is too long."

Before: "The scope must be under the directory of the
script URL."
After: "Failed to register a ServiceWorker:
The path of the provided scope ('http://localhost:9898/mysecretpath')
is not under the directory of the provided scriptURL
('http://localhost:9898/resources/empty-worker.js')."

BUG=436928
Committed: https://crrev.com/737a4ba8e6a63814c49f6bb5597e238275a3a810
Cr-Commit-Position: refs/heads/master@{#311428}

[falken, 2015-01-13 07:14:05]

falken@chromium.org changed reviewers:
+ dominicc@chromium.org

[dominicc (has gone to gerrit), 2015-01-14 06:16:38]

LGTM

One question inline I'm interested in, the comments are just suggestions.

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_dispatcher_host.cc:863:
base::ASCIIToUTF16(kServiceWorkerRegisterErrorPrefix) + error_message));
Realize that this is not in your patch, but do you know why do we sometimes
do...

no string conversion
ASCIIToUTF16
UTF8ToUTF16

?

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_utils.cc (right):

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_utils.cc:64: "') or scriptURL ('"
+ script_url.spec() +
script URL

with a space? WDYT?

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_utils.cc:64: "') or scriptURL ('"
+ script_url.spec() +
script URL

with a space? WDYT?

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_utils.cc:64: "') or scriptURL ('"
+ script_url.spec() +
script URL

with a space? Ditto below. WDYT?

[falken, 2015-01-14 07:29:21]

Thanks for the review.

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_dispatcher_host.cc (right):

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_dispatcher_host.cc:863:
base::ASCIIToUTF16(kServiceWorkerRegisterErrorPrefix) + error_message));
On 2015/01/14 06:16:37, dominicc wrote:
> Realize that this is not in your patch, but do you know why do we sometimes
> do...
> 
> no string conversion
> ASCIIToUTF16
> UTF8ToUTF16
> 
> ?

That's a good question. I found this post:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/3uzPhkB05Fg

Basically, use ASCIIToUTF16 for hard-coded constants for perf reasons, and
UTF8ToUTF16 otherwise. I don't think "no string conversion" is possible for
populating a base::string16 object.

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_utils.cc (right):

https://codereview.chromium.org/813673005/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_utils.cc:64: "') or scriptURL ('"
+ script_url.spec() +
On 2015/01/14 06:16:38, dominicc wrote:
> script URL
> 
> with a space? WDYT?

I like "scriptURL" as it's the parameter to ServiceWorkerContainer.register().

[falken, 2015-01-14 07:30:45]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2015-01-14 07:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813673005/60001

[commit-bot: I haz the power, 2015-01-14 07:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 07:36:04]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[falken, 2015-01-14 07:38:07]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2015-01-14 07:38:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813673005/60001

[commit-bot: I haz the power, 2015-01-14 08:30:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-14 08:31:24]

Patchset 4 (id:??) landed as
https://crrev.com/737a4ba8e6a63814c49f6bb5597e238275a3a810
Cr-Commit-Position: refs/heads/master@{#311428}