Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Issue 813643002: MediaCodecBridge: reconfigure AudioTrack when sample rate changes. (Closed)

Created:
6 years ago by gunsch
Modified:
6 years ago
Reviewers:
qinmin, xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaCodecBridge: reconfigure AudioTrack when sample rate changes. R=qinmin@chromium.org,xhwang@chromium.org BUG=443012 Committed: https://crrev.com/f9e882d11000bca774ba8799549bef15210983e3 Cr-Commit-Position: refs/heads/master@{#308856}

Patch Set 1 #

Total comments: 2

Patch Set 2 : combine conditionals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 4 chunks +39 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
Here's a bugfix. Context is in the bug. I don't know if I'm the most ...
6 years ago (2014-12-17 01:33:48 UTC) #1
xhwang
I skimmed the change and it looks good. I'll defer to qinmin@ to finish the ...
6 years ago (2014-12-17 17:19:30 UTC) #2
qinmin
lgtm % nit https://codereview.chromium.org/813643002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java (right): https://codereview.chromium.org/813643002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode573 media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:573: if (!reconfigureAudioTrack(newFormat)) { nit: simply combine ...
6 years ago (2014-12-17 18:12:54 UTC) #3
gunsch
https://codereview.chromium.org/813643002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java (right): https://codereview.chromium.org/813643002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode573 media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:573: if (!reconfigureAudioTrack(newFormat)) { On 2014/12/17 18:12:54, qinmin wrote: > ...
6 years ago (2014-12-17 19:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813643002/20001
6 years ago (2014-12-17 19:49:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-17 20:44:56 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 20:45:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9e882d11000bca774ba8799549bef15210983e3
Cr-Commit-Position: refs/heads/master@{#308856}

Powered by Google App Engine
This is Rietveld 408576698