Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/analysis_server/lib/src/get_handler.dart

Issue 813563007: improve completion performance status page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/get_handler.dart b/pkg/analysis_server/lib/src/get_handler.dart
index 80774b5c00a53bf2f5b211cfb5b0efd79b02f64f..41b4edf7e4d12ccecab0c95219d2e1b78dc6393a 100644
--- a/pkg/analysis_server/lib/src/get_handler.dart
+++ b/pkg/analysis_server/lib/src/get_handler.dart
@@ -12,6 +12,7 @@ import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/domain_completion.dart';
import 'package:analysis_server/src/socket_server.dart';
import 'package:analyzer/file_system/file_system.dart';
+import 'package:analyzer/instrumentation/instrumentation.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/java_engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -567,6 +568,7 @@ class GetHandler {
response.write('<p>No performance stats yet</p>');
return;
}
+ response.write('<h2>Last Completion Performance</h2>');
response.write('<table>');
_writeRow(response, ['Elapsed', '', 'Operation'], header: true);
performance.operations.forEach((OperationPerformance op) {
@@ -588,15 +590,31 @@ class GetHandler {
}
response.write('</table>');
if (handler.performanceList.length > 0) {
+ response.write('<h2>Last Completion Summary</h2>');
response.write('<table>');
_writeRow(
response,
- ['Milliseconds', '', '# Notifications', '', '# Suggestions', '', 'Snippet'],
+ [
+ 'Start Time',
+ '',
+ 'First (ms)',
+ '',
+ 'Complete (ms)',
+ '',
+ '# Notifications',
+ '',
+ '# Suggestions',
+ '',
+ 'Snippet'],
header: true);
handler.performanceList.forEach((CompletionPerformance performance) {
_writeRow(
response,
[
+ performance.start,
+ '&nbsp;&nbsp;',
+ performance.firstNotificationInMilliseconds,
+ '&nbsp;&nbsp;',
performance.elapsedInMilliseconds,
'&nbsp;&nbsp;',
performance.notificationCount,

Powered by Google App Engine
This is Rietveld 408576698