Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 813563007: improve completion performance status page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/get_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index 06c518864c36fff5b531cbcf05cb669c6130bfcb..9252382c0bcf178a0fb4a1bd647fe47df0c4aa12 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -175,7 +175,7 @@ class CompletionDomainHandler implements RequestHandler {
int notificationCount = 0;
manager.results(completionRequest).listen((CompletionResult result) {
++notificationCount;
- performance.logElapseTime("notification $notificationCount", () {
+ performance.logElapseTime("notification $notificationCount send", () {
sendCompletionNotification(
completionId,
result.replacementOffset,
@@ -183,6 +183,9 @@ class CompletionDomainHandler implements RequestHandler {
result.suggestions,
result.last);
});
+ if (notificationCount == 1) {
+ performance.logFirstNotificationComplete('notification 1 complete');
+ }
if (result.last) {
performance.notificationCount = notificationCount;
performance.suggestionCount = result.suggestions.length;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/get_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698