Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: Source/modules/serviceworkers/CacheTest.cpp

Issue 813513004: [bindings] Remove all the usages of Handle<> from binding templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/CacheTest.cpp
diff --git a/Source/modules/serviceworkers/CacheTest.cpp b/Source/modules/serviceworkers/CacheTest.cpp
index e034e7a6d2398579ac0ab33328ad22cd0b0491ae..ced7b989b768462a48703b461e05c6e87258615b 100644
--- a/Source/modules/serviceworkers/CacheTest.cpp
+++ b/Source/modules/serviceworkers/CacheTest.cpp
@@ -491,7 +491,7 @@ TEST_F(ServiceWorkerCacheTest, KeysResponseTest)
ScriptPromise result = cache->keys(scriptState(), exceptionState());
ScriptValue scriptValue = getResolveValue(result);
- Vector<v8::Handle<v8::Value> > requests = toImplArray<v8::Handle<v8::Value> >(scriptValue.v8Value(), 0, isolate(), exceptionState());
+ Vector<v8::Local<v8::Value> > requests = toImplArray<v8::Local<v8::Value> >(scriptValue.v8Value(), 0, isolate(), exceptionState());
EXPECT_EQ(expectedUrls.size(), requests.size());
for (int i = 0, minsize = std::min(expectedUrls.size(), requests.size()); i < minsize; ++i) {
Request* request = V8Request::toImplWithTypeCheck(isolate(), requests[i]);
@@ -543,7 +543,7 @@ TEST_F(ServiceWorkerCacheTest, MatchAllAndBatchResponseTest)
ScriptPromise result = cache->matchAll(scriptState(), stringToRequestInfo("http://some.url/"), options, exceptionState());
ScriptValue scriptValue = getResolveValue(result);
- Vector<v8::Handle<v8::Value> > responses = toImplArray<v8::Handle<v8::Value> >(scriptValue.v8Value(), 0, isolate(), exceptionState());
+ Vector<v8::Local<v8::Value> > responses = toImplArray<v8::Local<v8::Value> >(scriptValue.v8Value(), 0, isolate(), exceptionState());
EXPECT_EQ(expectedUrls.size(), responses.size());
for (int i = 0, minsize = std::min(expectedUrls.size(), responses.size()); i < minsize; ++i) {
Response* response = V8Response::toImplWithTypeCheck(isolate(), responses[i]);
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698