Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813503003: Move files from chrome/browser/history to components/history (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
droger
CC:
browser-components-watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@favicon-owners
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files from chrome/browser/history to components/history Move files from chrome/browser/history that have no dependency on chrome or content to components/history. BUG=370850 Committed: https://crrev.com/a4d364e2706001b2149e65e540827cbe61a2f686 Cr-Commit-Position: refs/heads/master@{#311513}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Add missing #include of base/macros.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -599 lines) Patch
M chrome/browser/history/android/android_provider_backend.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/android/android_urls_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/history/android/android_urls_sql_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/history/android/android_urls_sql_handler.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/history/android/urls_sql_handler.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/history/android/urls_sql_handler.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/browser/history/android/urls_sql_handler_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
D chrome/browser/history/android/visit_sql_handler.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/history/android/visit_sql_handler.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M chrome/browser/history/android/visit_sql_handler_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/history/history_unittest_base.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/history/history_unittest_base.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/history/top_sites_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/history.gypi View 2 chunks +11 lines, -1 line 0 comments Download
M components/history/core/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/history/core/android/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + components/history/core/android/android_urls_sql_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/history/core/android/android_urls_sql_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/history/core/android/urls_sql_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/history/core/android/urls_sql_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/history/core/android/visit_sql_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/history/core/android/visit_sql_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/test/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A + components/history/core/test/history_unittest_base.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
A + components/history/core/test/history_unittest_base.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
sdefresne
Please take a look.
5 years, 11 months ago (2015-01-13 18:20:39 UTC) #2
droger
https://codereview.chromium.org/813503003/diff/1/chrome/browser/history/android/urls_sql_handler_unittest.cc File chrome/browser/history/android/urls_sql_handler_unittest.cc (right): https://codereview.chromium.org/813503003/diff/1/chrome/browser/history/android/urls_sql_handler_unittest.cc#newcode1 chrome/browser/history/android/urls_sql_handler_unittest.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-14 13:28:37 UTC) #3
sdefresne
On 2015/01/14 at 13:28:37, droger wrote: > https://codereview.chromium.org/813503003/diff/1/chrome/browser/history/android/urls_sql_handler_unittest.cc > File chrome/browser/history/android/urls_sql_handler_unittest.cc (right): > > https://codereview.chromium.org/813503003/diff/1/chrome/browser/history/android/urls_sql_handler_unittest.cc#newcode1 ...
5 years, 11 months ago (2015-01-14 14:32:59 UTC) #4
sdefresne
PTAL https://codereview.chromium.org/813503003/diff/1/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/813503003/diff/1/chrome/chrome_tests_unit.gypi#newcode116 chrome/chrome_tests_unit.gypi:116: 'history/core/test/history_unittest_base.cc', On 2015/01/14 at 13:28:37, droger wrote: > ...
5 years, 11 months ago (2015-01-14 15:31:52 UTC) #5
droger
lgtm
5 years, 11 months ago (2015-01-14 15:51:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813503003/40001
5 years, 11 months ago (2015-01-14 17:31:51 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 18:12:27 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:14:30 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a4d364e2706001b2149e65e540827cbe61a2f686
Cr-Commit-Position: refs/heads/master@{#311513}

Powered by Google App Engine
This is Rietveld 408576698