sky/engine/core/page/Page.cpp - Issue 813493003: Only the main document should have a StyleEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/page/Page.cpp

Issue 813493003: Only the main document should have a StyleEngine. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/page/Page.cpp

diff --git a/sky/engine/core/page/Page.cpp b/sky/engine/core/page/Page.cpp

index ae9af7e730d25c0cbfd1d0c54cb878c266c32ce3..af0be64c5327a5c065d0f08a566cad1043b007f7 100644

--- a/sky/engine/core/page/Page.cpp

+++ b/sky/engine/core/page/Page.cpp

@@ -223,7 +223,7 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

}

break;

case SettingsDelegate::FontFamilyChange:

- if (mainFrame()->document())

+ if (mainFrame()->document() && mainFrame()->document()->isActive())

mainFrame()->document()->styleEngine()->updateGenericFontFamilySettings();

setNeedsRecalcStyleInAllFrames();

break;

« no previous file with comments | « sky/engine/core/html/HTMLStyleElement.cpp ('k') | no next file » | no next file with comments »