Issue 813493003: Only the main document should have a StyleEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813493003: Only the main document should have a StyleEngine. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
eseidel, ojan

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Only the main document should have a StyleEngine. In Sky <style> elements in import documents don't apply to the main document, so we don't need the StyleEngine to be aware of the import tree. This change makes us only create the StyleEngine for active documents. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/df15a8863a78b6c61a76c08c8a993b96eb5839b9

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -74 lines)			Patch
M	sky/engine/core/dom/Document.cpp	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.h	View	6 chunks	+0 lines, -11 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.cpp	View	12 chunks	+9 lines, -50 lines	0 comments	Download
M	sky/engine/core/dom/StyleSheetCollection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.cpp	View	4 chunks	+9 lines, -6 lines	0 comments	Download
M	sky/engine/core/page/Page.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years ago (2014-12-16 21:15:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
df15a8863a78b6c61a76c08c8a993b96eb5839b9 (presubmit successful).