Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 813483005: Prepend jinja2 path for hermeticity. (Closed)

Created:
5 years, 11 months ago by bradn
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepend jinja2 path for hermeticity. On systems with an older local install, appending the third_party path to jinja2 will result in the local install being used. Switching to prepending to avoid this. BUG=470543 TEST=local R=ncbray@chromium.org,jamesr@chromium.org Committed: https://crrev.com/455590124cbf51420078e8230f4d03aaf20fa492 Cr-Commit-Position: refs/heads/master@{#322712}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/nacl/generator/generate_nacl_bindings.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
bradn
5 years, 11 months ago (2015-01-02 03:22:50 UTC) #1
Nick Bray (chromium)
LGTM, just make sure to rebase and retry due to the time lag.
5 years, 9 months ago (2015-03-25 18:24:38 UTC) #2
Nick Bray (chromium)
FYI for the mojo OWNERS: this script is deprecated and we'll switch over to the ...
5 years, 9 months ago (2015-03-25 18:25:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813483005/20001
5 years, 9 months ago (2015-03-25 18:46:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51857)
5 years, 9 months ago (2015-03-25 19:00:54 UTC) #8
tfarina
James, could you approve this? I'm still being hit by this.
5 years, 8 months ago (2015-03-28 19:24:51 UTC) #10
jamesr
lgtm
5 years, 8 months ago (2015-03-28 22:26:22 UTC) #11
tfarina
Thanks, I'm checking the cq box.
5 years, 8 months ago (2015-03-28 22:33:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813483005/20001
5 years, 8 months ago (2015-03-28 22:33:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-28 23:20:25 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-03-28 23:21:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/455590124cbf51420078e8230f4d03aaf20fa492
Cr-Commit-Position: refs/heads/master@{#322712}

Powered by Google App Engine
This is Rietveld 408576698