Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813473003: replace COMPILE_ASSERT with static_assert in core/inspector/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in core/inspector/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/inspector/CodeGeneratorInspector.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/CodeGeneratorInspectorStrings.py View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@vsevik: PTAL.
6 years ago (2014-12-16 22:42:50 UTC) #2
vsevik
lgtm
6 years ago (2014-12-17 10:40:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813473003/1
6 years ago (2014-12-17 10:41:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42295)
6 years ago (2014-12-17 12:52:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813473003/1
6 years ago (2014-12-17 14:15:32 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-17 15:17:25 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187377

Powered by Google App Engine
This is Rietveld 408576698