Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: Source/core/page/PageSerializer.h

Issue 813453002: Oilpan: have PageSerializer accurately handle its GCed references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/PageSerializer.h
diff --git a/Source/core/page/PageSerializer.h b/Source/core/page/PageSerializer.h
index e33d8b4e35beebef46bb592338522392ba30346c..aac32b651dca366054631128dd9df7534d5639bd 100644
--- a/Source/core/page/PageSerializer.h
+++ b/Source/core/page/PageSerializer.h
@@ -31,6 +31,7 @@
#ifndef PageSerializer_h
#define PageSerializer_h
+#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/KURLHash.h"
#include "wtf/HashMap.h"
@@ -55,7 +56,8 @@ struct SerializedResource;
// This class is used to serialize a page contents back to text (typically HTML).
// It serializes all the page frames and retrieves resources such as images and CSS stylesheets.
-class PageSerializer {
+class PageSerializer final {
+ STACK_ALLOCATED();
public:
explicit PageSerializer(Vector<SerializedResource>*);
@@ -84,10 +86,12 @@ private:
Vector<SerializedResource>* m_resources;
ListHashSet<KURL> m_resourceURLs;
- HashMap<LocalFrame*, KURL> m_blankFrameURLs;
+
+ using BlankFrameURLMap = WillBeHeapHashMap<RawPtrWillBeMember<LocalFrame>, KURL>;
+ BlankFrameURLMap m_blankFrameURLs;
unsigned m_blankFrameCounter;
};
-}
+} // namespace blink
-#endif
+#endif // PageSerializer_h
« no previous file with comments | « no previous file | Source/core/page/PageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698